Address Snippet issues#24
Open
andrew-tram wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
To address - #14 |
Contributor
Author
|
@nitind , I'm not able to assign reviewers, but letting you know it is ready whenever you have a moment. Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SnippetsPluginwas missing astop()method, so snippets were never saved when Eclipse closed normally.UserModelDumperopened aFileOutputStreamto writeuser.xmlbut never closed it (the close call was commented out), leaving the file at 0 bytes on exit.The deeper persistence bug was in
SnippetManager.getPaletteRoot(), which created the palette root without callingconnect(). This meant the manager was never notified when snippets were added (e.g. via import), sosaveDefinitions()always wrote stale data. Related to this,SnippetsView.dispose()was callingdisconnect()on a field that was always null.The Import button in the Customize dialog was always greyed out because it was initialized disabled and only enabled on selection. So fixed to be enabled by default. Finally,
AccessibleTableViewerwas unconditionally casting the label provider toILabelProviderbefore checking its type, causing a crash due to OSGi classloader isolation.org.eclipse.jfacewas also added as an explicitRequire-Bundledependency since relying on it transitively doesn't guarantee classloader sharing.