Skip to content

chore: update zenoh-test to use workspace version#2597

Merged
OlivierHecart merged 3 commits into
eclipse-zenoh:mainfrom
ZettaScaleLabs:chore/use-workspace-version
May 13, 2026
Merged

chore: update zenoh-test to use workspace version#2597
OlivierHecart merged 3 commits into
eclipse-zenoh:mainfrom
ZettaScaleLabs:chore/use-workspace-version

Conversation

@diogomatsubara
Copy link
Copy Markdown
Contributor

@diogomatsubara diogomatsubara commented May 11, 2026

Description

zenoh-test crate introduced in #2573 fails the release workflow https://github.com/eclipse-zenoh/zenoh/actions/runs/25643820800 due to the pinned version. It should use the workspace version instead.

What does this PR do?

Changes zenoh-test Cargo.toml to use version from the workspace instead of pinning it to 1.9.0

Why is this change needed?

Avoid failures in the release workflow

Related Issues

#2573


🏷️ Label-Based Checklist

Based on the labels applied to this PR, please complete these additional requirements:

Labels: internal

🏠 Internal Change

This PR is marked as internal (not user-facing):

  • No API changes - Public APIs unchanged
  • No behavior changes - External behavior identical
  • Refactoring/maintenance - Code improvements only
  • Tests still pass - All existing tests pass without modification

Lighter review: Internal changes may have lighter review requirements.

Instructions:

  1. Check off items as you complete them (change - [ ] to - [x])
  2. The PR checklist CI will verify these are completed

This checklist updates automatically when labels change, but preserves your checked boxes.

@diogomatsubara diogomatsubara requested a review from evshary May 11, 2026 14:55
@diogomatsubara diogomatsubara added the internal Changes not included in the changelog label May 11, 2026
Copy link
Copy Markdown
Contributor

@evshary evshary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @diogomatsubara
I believe the coverage issue in the CI is not related to the PR.

@diogomatsubara
Copy link
Copy Markdown
Contributor Author

Thank you @diogomatsubara I believe the coverage issue in the CI is not related to the PR.

Looks like the code coverage will keep failing until we can update one of our dependencies on the zenoh-plugin-rest. Nightly got updated here: rust-lang/rust#155433 which in turn triggers the issue with rustix bytecodealliance/rustix#1620 and in our dependency chain, a very old version of rustix is pulled in by the rest plugin -> tide -> async-h1 -> async-io -> rustix

@diogomatsubara
Copy link
Copy Markdown
Contributor Author

CY pointed out to me on Discord that #2176 is the PR that should take care of replacing tide as dependency from the rest plugin.

@wyfo wyfo mentioned this pull request May 12, 2026
7 tasks
@OlivierHecart OlivierHecart merged commit 5808490 into eclipse-zenoh:main May 13, 2026
46 of 50 checks passed
@OlivierHecart OlivierHecart deleted the chore/use-workspace-version branch May 13, 2026 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

internal Changes not included in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants