Skip to content

Remove providing execute permission to the extracted library #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alisihab wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove providing execute permission to the extracted library #534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions src/main/java/com/eclipsesource/v8/LibraryLoader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ static void loadLibrary(final String tempDirectory) {
return;

String path = null;

if (tempDirectory != null) {
path = tempDirectory;
} else {
Expand Down Expand Up @@ -157,7 +157,6 @@ static boolean extract(final String fileName, final String mappedName, final Str
}
os.close();
is.close();
chmod("755", fileName);
if (load(fileName, message)) {
return true;
}
Expand All @@ -182,13 +181,4 @@ static boolean extract(final String fileName, final String mappedName, final Str
return false;
}

static void chmod(final String permision, final String path) {
if (PlatformDetector.OS.isWindows()) {
return;
}
try {
Runtime.getRuntime().exec(new String[] { "chmod", permision, path }).waitFor(); //$NON-NLS-1$
} catch (Throwable e) {
}
}
}