Skip to content

【fix】fix-cross-path-attack-risk #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
captain6541 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

【fix】fix-cross-path-attack-risk #586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/main/java/com/eclipsesource/v8/NodeJS.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ public void invoke(final V8Object receiver, final V8Array parameters) {
try {
File startupScript = createTemporaryScriptFile(STARTUP_SCRIPT, STARTUP_SCRIPT_NAME);
try {
v8.createNodeRuntime(startupScript.getAbsolutePath());
v8.createNodeRuntime(startupScript.getCanonicalPath());
} finally {
startupScript.delete();
}
Expand Down Expand Up @@ -165,9 +165,11 @@ public V8Object require(final File file) {
v8.checkThread();
V8Array requireParams = new V8Array(v8);
try {
requireParams.push(file.getAbsolutePath());
requireParams.push(file.getCanonicalPath());
return (V8Object) require.call(null, requireParams);
} finally {
} catch (IOException e) {
throw new RuntimeException(e);
}finally {
requireParams.close();
}
}
Expand Down Expand Up @@ -202,8 +204,10 @@ private V8Function createScriptExecutionCallback(final File file) {
public Object invoke(final V8Object receiver, final V8Array parameters) {
V8Array requireParams = new V8Array(v8);
try {
requireParams.push(file.getAbsolutePath());
requireParams.push(file.getCanonicalPath());
return require.call(null, requireParams);
} catch (IOException e) {
throw new RuntimeException(e);
} finally {
requireParams.close();
}
Expand Down