feat: add dispatching filters for filters which work on both tabular/field data #264
Open
aaron-hopkinson wants to merge 2 commits intorefactor/filter_registriesfrom
Open
feat: add dispatching filters for filters which work on both tabular/field data #264aaron-hopkinson wants to merge 2 commits intorefactor/filter_registriesfrom
aaron-hopkinson wants to merge 2 commits intorefactor/filter_registriesfrom
Conversation
Contributor
Author
|
Can be reviewed, but please do not merge until after #263 |
Contributor
Author
|
(Note: tests are just temporary copy and pastes from the specialist versions – just to give some independent test coverage. They don't need to be reviewed in detail because they will go away very soon 🙂) |
HCookie
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a third collection of filters, dispatching filters, for those which work on both tabular and field datasets. These new filters currently dispatch to instances of the specialised versions based on the configuration format and data types.
The eventual goal is to align interfaces and inline implementations in a single class. This will allow for supporting both versions without breaking changes for end users.
What issue or task does this change relate to?
Supporting tabular datasets.
Additional notes
Note: these are added to a parallel registry, and so are still not callable from
anemoi-datasetswithout further changes.As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/
By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.