Skip to content

feat: add dispatching filters for filters which work on both tabular/field data #264

Open
aaron-hopkinson wants to merge 2 commits intorefactor/filter_registriesfrom
feat/dispatching_filters
Open

feat: add dispatching filters for filters which work on both tabular/field data #264
aaron-hopkinson wants to merge 2 commits intorefactor/filter_registriesfrom
feat/dispatching_filters

Conversation

@aaron-hopkinson
Copy link
Contributor

Description

Add a third collection of filters, dispatching filters, for those which work on both tabular and field datasets. These new filters currently dispatch to instances of the specialised versions based on the configuration format and data types.

The eventual goal is to align interfaces and inline implementations in a single class. This will allow for supporting both versions without breaking changes for end users.

What issue or task does this change relate to?

Supporting tabular datasets.

Additional notes

Note: these are added to a parallel registry, and so are still not callable from anemoi-datasets without further changes.

As a contributor to the Anemoi framework, please ensure that your changes include unit tests, updates to any affected dependencies and documentation, and have been tested in a parallel setting (i.e., with multiple GPUs). As a reviewer, you are also responsible for verifying these aspects and requesting changes if they are not adequately addressed. For guidelines about those please refer to https://anemoi.readthedocs.io/en/latest/

By opening this pull request, I affirm that all authors agree to the Contributor License Agreement.

@aaron-hopkinson
Copy link
Contributor Author

Can be reviewed, but please do not merge until after #263

@aaron-hopkinson
Copy link
Contributor Author

(Note: tests are just temporary copy and pastes from the specialist versions – just to give some independent test coverage. They don't need to be reviewed in detail because they will go away very soon 🙂)

@github-project-automation github-project-automation bot moved this from To be triaged to For merging in Anemoi-dev Mar 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: For merging

Development

Successfully merging this pull request may close these issues.

2 participants