Prevent periodic halo double-counting in conservative spherical polygon interpolation (H32 NodeColumns → H64)#364
Draft
Copilot wants to merge 4 commits into
Draft
Conversation
Agent-Logs-Url: https://github.com/ecmwf/atlas/sessions/a5a0be3c-d979-4d61-be90-572dd8c81947 Co-authored-by: sbrdar <23637931+sbrdar@users.noreply.github.com>
Agent-Logs-Url: https://github.com/ecmwf/atlas/sessions/a5a0be3c-d979-4d61-be90-572dd8c81947 Co-authored-by: sbrdar <23637931+sbrdar@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix large halo issue in ConvexSphericalPolygonInterpolation
Prevent periodic halo double-counting in conservative spherical polygon interpolation (H32 NodeColumns → H64)
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large source halos in
conservative-spherical-polygoninterpolation could include geographically identical periodic halo polygons in addition to owned source polygons, producing inflated target values near the periodic boundary (notably for H32NodeColumnsremapped to H64). This change removes that duplicate-path contribution and adds a focused regression for constant-field preservation in the affected configuration.Source KD-tree deduplication path (NodeColumns)
ConservativeSphericalPolygonInterpolation::build_source_kdtree(...).node_halo || node_ghostwhen deciding whether a node should go through remote(partition, remote_index)deduplication.Regression coverage for the reported case
regression_halo_periodic_source_nodecolumnsintest_interpolation_conservative.cc.Grid("H32") -> Grid("H64")withsrc_cell_data=false,tgt_cell_data=true.0.0,-2.5,1.0), guarding against periodic-boundary amplification regressions.Representative change
💣💥☠️ Static Analyzer Report ☠️💥💣
https://sites.ecmwf.int/docs/atlas/static-analyzer/PR-364