Skip to content

Fix missing coordinate variable attributes#1001

Merged
sandorkertesz merged 2 commits into
developfrom
fix/coord-attrs
May 21, 2026
Merged

Fix missing coordinate variable attributes#1001
sandorkertesz merged 2 commits into
developfrom
fix/coord-attrs

Conversation

@pawel-wolff
Copy link
Copy Markdown
Contributor

Description

Since v1.0rc a regression bug was introduced: attributes of some coordinate variables, notably "forecast_reference_time" and "valid_time", were gone.

This PR fixes the bug, provides relevant tests and adds standard_name and long_name attributes for the coordinate variable member.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.51%. Comparing base (df0cc0b) to head (df964b3).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1001      +/-   ##
===========================================
+ Coverage    81.48%   81.51%   +0.03%     
===========================================
  Files          236      236              
  Lines        15444    15472      +28     
  Branches       754      756       +2     
===========================================
+ Hits         12584    12612      +28     
  Misses        2634     2634              
  Partials       226      226              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pawel-wolff pawel-wolff requested a review from sandorkertesz May 21, 2026 06:23
@sandorkertesz sandorkertesz merged commit 84aa271 into develop May 21, 2026
140 of 148 checks passed
@sandorkertesz sandorkertesz deleted the fix/coord-attrs branch May 21, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants