File-pattern with hive partitioning#659
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #659 +/- ##
===========================================
+ Coverage 90.86% 90.99% +0.13%
===========================================
Files 160 162 +2
Lines 12145 12363 +218
Branches 593 605 +12
===========================================
+ Hits 11035 11250 +215
- Misses 930 932 +2
- Partials 180 181 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements #637.
Adds the
hive_partitioningoption to the "file-pattern" source.The examples below are using these GRIB data files from the tests:
hive_partitioning=False
This is the default, the "file-pattern" source behaves as before. Namely:
hive_partitioning=True
from_source()returns an object that only supports thesel()methodsel()substitutes its args and kwargs into the pattern and collects the matching files. During the scan it only enters directories matching the pattern. The collected file paths are handled as a "multi" source. For GRIB data the result will be a single FieldList.Remarks: