Skip to content

improve/fix xr splitter#688

Merged
sandorkertesz merged 8 commits into
developfrom
feature/improve-xr-splitter
May 6, 2025
Merged

improve/fix xr splitter#688
sandorkertesz merged 8 commits into
developfrom
feature/improve-xr-splitter

Conversation

@pawel-wolff
Copy link
Copy Markdown
Contributor

xr_engine splitter improved/fixed in case "split_dims" contains multiple keys

If to_xarray converter gets "split_dims" keyword, a slight change of behaviour is introduced: it returns a tuple with:

  • a list of xarray Datasets
  • a corresponding list of dictionaries with values of the spitting keys.
    Moreover, the two above are always lists, even if they are of length 1 (for consistency of the behaviour).

TBD if we really want to introduce this new behaviour since the values of the splitting keys can be obtained via using "ensure_dims" keyword of to_xarray.

A test and a corresponding mid-size test dataset was added.

@FussyDuck
Copy link
Copy Markdown

FussyDuck commented May 2, 2025

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.01%. Comparing base (5dd3946) to head (20b6171).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #688   +/-   ##
========================================
  Coverage    91.01%   91.01%           
========================================
  Files          162      162           
  Lines        12385    12391    +6     
  Branches       609      609           
========================================
+ Hits         11272    11278    +6     
  Misses         932      932           
  Partials       181      181           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pawel-wolff pawel-wolff requested a review from sandorkertesz May 5, 2025 11:47
@sandorkertesz
Copy link
Copy Markdown
Collaborator

@pawel-wolff, thank you very much for this fix and improvement in the Xarray engine. I fully agree with your decision to change the return type when split_dims=True.

@sandorkertesz sandorkertesz merged commit 7cfd5e2 into develop May 6, 2025
125 of 126 checks passed
@pawel-wolff pawel-wolff deleted the feature/improve-xr-splitter branch September 17, 2025 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants