Consistent GRIB handle usage in field#968
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #968 +/- ##
===========================================
+ Coverage 81.26% 81.64% +0.37%
===========================================
Files 223 226 +3
Lines 14624 14980 +356
Branches 718 745 +27
===========================================
+ Hits 11884 12230 +346
- Misses 2521 2524 +3
- Partials 219 226 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR implements the following changes for fields generated from GRIB messages:
set()we cannot access any raw (GRIB) metadata on the new field. The reason for this is that the original GRIB message/handle is not updated whenset()is called and it goes out of sync with the updated components of the field. Note: previously the (potentially out-of-sync) GRIB metadata was available on the modified field.sync()method.Contributor Declaration
By opening this pull request, I affirm the following: