Feature/xr engine aux coords#969
Merged
Merged
Conversation
…a do not form a hypercube Tests added
Docstrings on `aux_coord` improved Error message on conflicting values for aux coords improved
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #969 +/- ##
===========================================
+ Coverage 81.26% 81.38% +0.12%
===========================================
Files 223 224 +1
Lines 14624 14719 +95
Branches 718 718
===========================================
+ Hits 11884 11979 +95
Misses 2521 2521
Partials 219 219 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
aux_coordskwarg to the Xarray engine. It allows to declare 1- or multi-dimensional auxiliary coordinate variables whose values are derived from any metadata key (format-agnostic, format-specific or virtual, issued from remapping). The value ofaux_coords, if notNone, should be a dictionary with:(metadata_key: str, dataset_dimension(s): str or iterable of str)Dedicated tests added.
A new how-to notebook added.
As an extra:
ListDiff._compareimproved and now provides a sensible error when data do not form a hypercubeContributor Declaration
By opening this pull request, I affirm the following: