Skip to content

Implement set method for non-grib fields#981

Merged
sandorkertesz merged 1 commit into
developfrom
feature/set-non-grib-field
May 5, 2026
Merged

Implement set method for non-grib fields#981
sandorkertesz merged 1 commit into
developfrom
feature/set-non-grib-field

Conversation

@sandorkertesz
Copy link
Copy Markdown
Collaborator

Description

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@sandorkertesz sandorkertesz changed the title Set non-grib field Implement set for non-grib fields May 5, 2026
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.10101% with 79 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.49%. Comparing base (8430cdc) to head (1215264).

Files with missing lines Patch % Lines
tests/netcdf/test_netcdf_set_data.py 22.22% 28 Missing ⚠️
tests/netcdf/test_netcdf_set_geography.py 29.41% 24 Missing ⚠️
tests/netcdf/test_netcdf_set_parameter.py 30.00% 14 Missing ⚠️
tests/netcdf/test_netcdf_set_time.py 46.15% 7 Missing ⚠️
tests/netcdf/test_netcdf_set_vertical.py 45.45% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #981      +/-   ##
===========================================
- Coverage    81.77%   81.49%   -0.29%     
===========================================
  Files          227      235       +8     
  Lines        15082    15275     +193     
  Branches       746      751       +5     
===========================================
+ Hits         12334    12448     +114     
- Misses        2523     2602      +79     
  Partials       225      225              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sandorkertesz sandorkertesz changed the title Implement set for non-grib fields Implement set method for non-grib fields May 5, 2026
@sandorkertesz sandorkertesz merged commit 4283cc0 into develop May 5, 2026
137 of 144 checks passed
@sandorkertesz sandorkertesz deleted the feature/set-non-grib-field branch May 5, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants