adds --arch-dir argument to point to specific architecture directories#43
Open
pardallio wants to merge 4 commits into
Open
adds --arch-dir argument to point to specific architecture directories#43pardallio wants to merge 4 commits into
pardallio wants to merge 4 commits into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #43 +/- ##
===========================================
+ Coverage 40.66% 40.68% +0.01%
===========================================
Files 49 49
Lines 10156 10161 +5
===========================================
+ Hits 4130 4134 +4
- Misses 6026 6027 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In response to Issue #36
ecbundle build looks for archs either in the arch folder or in the running directory, so the simplest way to do it is just to pass --arch relative/path/from/working/directory/to/extra-archs/(...) but it seems highly non-ideal.
This PR allows an --arch-dir argument to be passed to ecbundle create, which populates the source directory with the folder given in arch-dir.
Contributor Declaration
By opening this pull request, I affirm the following: