Skip to content

Replace use of deprecated Library::lookup#84

Merged
wdeconinck merged 1 commit into
developfrom
fix/replace_deprecated_lookup
Feb 17, 2026
Merged

Replace use of deprecated Library::lookup#84
wdeconinck merged 1 commit into
developfrom
fix/replace_deprecated_lookup

Conversation

@marcosbento
Copy link
Copy Markdown
Contributor

@marcosbento marcosbento commented Feb 16, 2026

Description

Replace use of deprecated Library::lookup, to allow building after removing deprecated functionality from upstream eckit.

Contributor Declaration

By opening this pull request, I affirm the following:

  • All authors agree to the Contributor License Agreement.
  • The code follows the project's coding standards.
  • I have performed self-review and added comments where needed.
  • I have added or updated tests to verify that my changes are effective and functional.
  • I have run all existing tests and confirmed they pass.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 51.07%. Comparing base (cced373) to head (d6627cb).

Files with missing lines Patch % Lines
src/fckit/Log.cc 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop      #84   +/-   ##
========================================
  Coverage    51.07%   51.07%           
========================================
  Files           58       58           
  Lines         4854     4854           
  Branches       453      453           
========================================
  Hits          2479     2479           
  Misses        2375     2375           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@wdeconinck wdeconinck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect. I checked and the eckit version that introduced LibraryManager is 1.14 which matches the fckit minimum required version still.

@wdeconinck wdeconinck merged commit 2d27439 into develop Feb 17, 2026
191 checks passed
@wdeconinck wdeconinck deleted the fix/replace_deprecated_lookup branch February 17, 2026 09:56
wdeconinck added a commit that referenced this pull request Feb 23, 2026
* hotfix/0.14.2:
  Version 0.14.2
  Replace use of deprecated Library::lookup (#84)
  Add fortran linker flag submitted by AMD for AOCC (and Classic Flang) (#82)
  Workaround for failing fckit_test_shared_ptr with aocc/nvhpc/intel by detecting compiler bugs (#80)
  FCKIT_VENV_INSTALL: add a new ecbuild feature to control the (#78)
  Add miniumum cmake version check in wheel download macro (#75)
harshula added a commit to ACCESS-NRI/upstream-spack-packages that referenced this pull request May 13, 2026
harshula added a commit to harshula/spack-packages that referenced this pull request May 13, 2026
* Fixed in 0.14.2: ecmwf/fckit#84

Signed-off-by: Harshula Jayasuriya <harshula.jayasuriya@anu.edu.au>
harshula added a commit to ACCESS-NRI/upstream-spack-packages that referenced this pull request May 19, 2026
becker33 pushed a commit to spack/spack-packages that referenced this pull request May 20, 2026
#4828)

* Fixed in 0.14.2: ecmwf/fckit#84

Signed-off-by: Harshula Jayasuriya <harshula.jayasuriya@anu.edu.au>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants