Install a fckit_venv symlink to build/fckit_venv if FCKIT_VENV_INSTALL=OFF#90
Merged
Merged
Conversation
Member
Author
|
@awnawab could you please review if you have time? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #90 +/- ##
========================================
Coverage 51.07% 51.07%
========================================
Files 58 58
Lines 4854 4854
Branches 453 453
========================================
Hits 2479 2479
Misses 2375 2375 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
awnawab
approved these changes
Apr 9, 2026
Contributor
awnawab
left a comment
awnawab
left a comment
There was a problem hiding this comment.
Thanks for this fix @wdeconinck, it's a very clever workaround to the expensive venv installation problem 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fckit is installed with
ENABLE_FCKIT_VENV=ONandENABLE_FCKIT_VENV_INSTALL=OFF(OFF is default here), then there is a problem with downstream packages accessing the fypp-scripts.The install default is OFF because it is potentially a quite heavy install. This can still be solved though by installing a symlink to the
fckit_venvfrom the build dir. I realise this is dangerous because the build-dir may get wiped and the symlink may dangle; however it is better than nothing.