Remove explicit timeout in step-meter tests#273
Closed
tweska wants to merge 1 commit into
Closed
Conversation
Rely on default CTest timeout instead
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #273 +/- ##
========================================
Coverage 33.21% 33.21%
========================================
Files 374 374
Lines 41063 41063
Branches 1701 1701
========================================
Hits 13638 13638
Misses 27425 27425 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
I just realized that we are testing something that is not supported and that is the real issue: updating the meter at different rates (increase by 3 vs 4 steps in this case). |
Member
Author
|
Closed in favor of #274 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the explicit
TIMEOUT 10from the step-meter tests. My hope is that this will reduce the number of CI failures due to timeouts in these tests.🌈🌦️📖🚧 Documentation 🚧📖🌦️🌈
https://sites.ecmwf.int/docs/dev-section/multio/pull-requests/PR-273