Feat/fdb adapter

[mathleur]

Description

Contributor Declaration

By opening this pull request, I affirm the following:

• All authors agree to the Contributor License Agreement.
• The code follows the project's coding standards.
• I have performed self-review and added comments where needed.
• I have added or updated tests to verify that my changes are effective and functional.
• I have run all existing tests and confirmed they pass.

[Copilot]

Pull request overview

Adds new “meteo” adapters for building/serializing Qube structures from external list/constraint formats, while also refactoring core merge/union behavior and adding a new arena-style JSON serialization format.

Changes:

• Add FDB and MARS list adapters plus a JSON “constraints” export adapter in qubed-meteo.
• Refactor core merge API (union → append / append_many) and add utilities for copying/leaf-path extraction + Qube→Datacube conversion.
• Add arena-style JSON serialization/deserialization for Qube, and reorganize float coordinates into their own module.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 18 comments.

Show a summary per file

File	Description
qubed/tests/test_union.rs	Updates union tests to use append and adds a second test case.
qubed/src/serde/json.rs	Adds arena-style JSON (de)serialization + a roundtrip test.
qubed/src/qube.rs	Adds helper APIs (is_empty, node_dim, child dedup in create_child, path/copy helpers) and a new test.
qubed/src/merge.rs	Renames/rewrites union into append and adds append_many.
qubed/src/datacube.rs	Adds Datacube::coordinates() and Qube::to_datacubes(), wires append_datacube to append.
qubed/src/coordinates/mod.rs	Moves float coordinate type into a dedicated module and updates imports.
qubed/src/coordinates/floats.rs	New module for float coordinate storage/conversions.
qubed/src/compress.rs	Adds a merge_subtrees helper and tweaks doc comments.
qubed/Cargo.toml	Adds rayon dependency.
qubed-meteo/src/adapters/to_constraints.rs	New adapter to export Qube leaf paths into DSS-like JSON constraints objects.
qubed-meteo/src/adapters/mod.rs	Exposes new adapter modules.
qubed-meteo/src/adapters/mars_list.rs	New parser to build a Qube from an indented MARS list format.
qubed-meteo/src/adapters/fdb.rs	New parser to build a Qube from FDB-like comma-separated path strings.
qubed-meteo/src/adapters/dss_constraints.rs	Changes constraints ingestion to build/merge multiple Qubes using append_many.
qubed-meteo/examples/read_from_mars_list.rs	New example for timing MARS-list parsing and datacube conversion.
qubed-meteo/examples/read_from_dss_constraints.rs	Updates example input + adds timing output.
qubed-meteo/Cargo.toml	Adds rsfdb path dependency and a bin target configuration.
.gitignore	Ignores *.list files.
.github/workflows/ci.yml	Adjusts workflow triggers (adds pull_request_target labeled trigger).

Comments suppressed due to low confidence (3)

qubed/src/merge.rs:53

• internal_set_operation returns Option<Vec<NodeIdx>> but never returns None, and callers ignore the returned value. Consider simplifying this to return () (or return a meaningful result that’s actually used) to reduce dead/unclear code paths.

    /// Performs a set operation between two groups of nodes from two Qubes.
    fn internal_set_operation(
        &mut self,
        other: &mut Qube,
        self_ids: &Vec<NodeIdx>,
        other_ids: &Vec<NodeIdx>,
    ) -> Option<Vec<NodeIdx>> {
        let mut return_vec = Vec::new();

qubed/src/coordinates/mod.rs:13

• tiny_vec::TinyVec is imported in this module but no longer used (after moving float coordinates into floats.rs). Please remove the unused import to avoid warnings.

use std::hash::Hash;

use floats::FloatCoordinates;
use integers::IntegerCoordinates;
use strings::StringCoordinates;

use tiny_vec::TinyVec;

use crate::utils::tiny_ordered_set::TinyOrderedSet;

.github/workflows/ci.yml:29

• The added pull_request_target trigger (on any labeled event) will run this workflow on the base repo context, but the current actions/checkout configuration checks out the default ref (base), so it won’t actually test the PR’s code. If the intent is “run CI after approval”, consider filtering on a specific label and explicitly checking out the PR merge/head ref; if you do check out PR code under pull_request_target, ensure the workflow does not expose secrets to untrusted code.

  # Trigger after public PR approved for CI
  pull_request_target:
    types: [labeled]

jobs:
  build:

    runs-on: ubuntu-latest

    steps:
    - name: Checkout code
      uses: actions/checkout@v2

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.