Fix SDK minor bugs and publish v1.4.3#33
Conversation
- Add base_url keyword alias to CryptoClient and AsyncCryptoClient for backwards compatibility with code that uses base_url instead of server_url - Clarify easy.py encrypt/decrypt docstrings to explicitly state these are offline password-based functions, not server-connected operations - Bump version to 1.4.3 and publish to PyPI
|
Claude finished @thebenignhacker's task —— View job Security Review Complete ✅Performed comprehensive security-focused review of PR #33. Tasks
SummaryThis PR introduces minor SDK improvements with no security issues found. The changes are minimal and well-contained: Changed Files Analysis
Security Assessment (12-Point Checklist)✅ 1. Injection vulnerabilities: None. No SQL, command, or path traversal risks. ✅ 2. Authentication/authorization: No auth logic modified. ✅ 3. Insecure deserialization: No eval, exec, pickle, or dynamic code execution. ✅ 4. Hardcoded credentials: No secrets, keys, or credentials added. ✅ 5. SSRF/redirect risks: User-controlled URL is expected for client configuration. No automatic redirects. ✅ 6. Cryptographic misuse: No crypto operations modified. Docstring clarifications are accurate. ✅ 7. Prototype pollution: N/A (Python code only). ✅ 8. ReDoS: No regex patterns added or modified. ✅ 9. Command injection: No subprocess or shell commands. ✅ 10. Logic bugs: Parameter aliasing logic traced with 4 test cases - all correct:
✅ 11. Filter predicates: No filter logic modified. ✅ 12. Boolean expressions: The Key ObservationsBackwards Compatibility Addition (async_client.py:41, client.py:74)
Docstring Improvements (easy.py:40-84)
Code Quality Notes
ResultFINDINGS_COUNT=0 No security vulnerabilities identified. This PR is safe to merge. |
|
Manual review required. This PR did not meet auto-merge criteria:
|
Summary
Test plan