Skip to content

Fix scoper.php for FinalClassFixer - #39

Merged
TomasVotruba merged 1 commit into
ecsphp:mainfrom
SystematicCZ:systematic/fix-finalclass-scoper
Jul 20, 2026
Merged

Fix scoper.php for FinalClassFixer#39
TomasVotruba merged 1 commit into
ecsphp:mainfrom
SystematicCZ:systematic/fix-finalclass-scoper

Conversation

@SystematicCZ

@SystematicCZ SystematicCZ commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Fixes issue #24 by correcting the scoper.php rule for FinalInternalClassFixer

Scoper output before

❯ grep "private const DEFAULTS" \
  ./ecs-prefixed/vendor/friendsofphp/php-cs-fixer/src/Fixer/ClassNotation/FinalInternalClassFixer.php
    private const DEFAULTS = ['include' => ['internal'], 'exclude' => ['final', 'Entity', 'ECSPrefix202607\ORM\Entity', 'ECSPrefix202607\ORM\Mapping\Entity', 'ECSPrefix202607\Mapping\Entity', 'Document', 'ECSPrefix202607\ODM\Document']];

Scoper output after

❯ grep "private const DEFAULTS" \
  ./ecs-prefixed/vendor/friendsofphp/php-cs-fixer/src/Fixer/ClassNotation/FinalInternalClassFixer.php
    private const DEFAULTS = ['include' => ['internal'], 'exclude' => ['final', 'Entity', 'ORM\Entity', 'ORM\Mapping\Entity', 'Mapping\Entity', 'Document', 'ODM\Document']];

@TomasVotruba
TomasVotruba merged commit 717415b into ecsphp:main Jul 20, 2026
7 checks passed
@TomasVotruba

Copy link
Copy Markdown
Member

Looks good, thanks you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants