Fix sheet corner border positioning and styling#179
Merged
Conversation
Corner divs had `padding: 0 4px` shifting the box-drawing character ~9px inward, but were only offset by `-1px` from the sheet edge, so the └/┘/┌/┐ glyphs appeared floating well inside the box rather than sitting on the corners. Increase the offset to `-10px` horizontally and `-9px` vertically so each glyph's bar lines up with the sheet border. Also drop the dead `content:` declarations on .corner-bl / .corner-br (only valid on pseudo-elements; the actual glyphs come from inline spans).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adjusted the positioning and styling of the sheet corner borders to improve visual alignment and consistency.
Key Changes
.sheet::beforeand.sheet::after) fromtop: -10pxtotop: -9px±1pxto±10pxfor consistent offsetcontentproperty from bottom corner selectors (.corner-bland.corner-br) as it was invalid for non-pseudo-elementsbottom: -10pxtobottom: -9pxImplementation Details
The changes normalize the corner border positioning to use consistent
-9pxvertical offset and-10pxhorizontal offset across all four corners. The removal of thecontentproperty from the bottom corner classes suggests these elements rely on their HTML content rather than CSS-generated content.https://claude.ai/code/session_01A7yh22bp9YqwdmTdbMfXee