Skip to content

fix: debug server /tuning-history returns correct field names #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddycek merged 2 commits into from
Apr 9, 2026
Merged

fix: debug server /tuning-history returns correct field names #429

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc82c53
fix: debug server /tuning-history returns correct field names
eddycek Apr 9, 2026
07074b2
review: type record as CompletedTuningRecord, add missing fields
eddycek Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions src/main/debug/DebugServer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ import { analyzePID, analyzeTransferFunction } from '../analysis/PIDAnalyzer';
import { extractFlightPIDs } from '../analysis/PIDRecommender';
import { validateBBLHeader, enrichSettingsFromBBLHeaders } from '../analysis/headerValidation';
import { DEFAULT_FILTER_SETTINGS } from '@shared/types/analysis.types';
import type { CompletedTuningRecord } from '@shared/types/tuning-history.types';

const DEFAULT_PORT = 9300;
const MAX_LOG_LINES = 500;
Expand Down Expand Up @@ -471,16 +472,27 @@ async function getTuningHistory() {
profileId: currentProfile.id,
profileName: currentProfile.name,
totalSessions: records.length,
records: records.map((r: any) => ({
records: records.map((r: CompletedTuningRecord) => ({
id: r.id,
type: r.type,
tuningType: r.tuningType,
completedAt: r.completedAt,
phase: r.phase,
qualityScore: r.qualityScore,
startedAt: r.startedAt,
filterMetrics: r.filterMetrics,
pidMetrics: r.pidMetrics,
appliedChanges: r.appliedChanges,
dataQuality: r.dataQuality,
verificationMetrics: r.verificationMetrics,
verificationPidMetrics: r.verificationPidMetrics,
transferFunctionMetrics: r.transferFunctionMetrics,
verificationTransferFunctionMetrics: r.verificationTransferFunctionMetrics,
appliedFilterChanges: r.appliedFilterChanges,
appliedPIDChanges: r.appliedPIDChanges,
appliedFeedforwardChanges: r.appliedFeedforwardChanges,
filterLogId: r.filterLogId,
pidLogId: r.pidLogId,
quickLogId: r.quickLogId,
verificationLogId: r.verificationLogId,
convergence: r.convergence,
Comment on lines +484 to +493
Copy link

Copilot AI Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The history record type includes additional fields that are still omitted from this debug response (e.g., quickLogId and verificationTransferFunctionMetrics). Since the PR description calls out missing log IDs / transfer-function metrics, consider including these fields (or explicitly documenting why they’re excluded) so tooling can see the full data set.

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Owner Author

@eddycek eddycek Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed — added quickLogId and verificationTransferFunctionMetrics in 07074b2.

qualityScore: r.qualityScore,
bfPidProfileIndex: r.bfPidProfileIndex,
})),
};
} catch (err: any) {
Expand Down
Loading