Skip to content

Sprint/sprint 15#32

Merged
edgarbnt merged 6 commits into
mainfrom
sprint/sprint-15
May 10, 2026
Merged

Sprint/sprint 15#32
edgarbnt merged 6 commits into
mainfrom
sprint/sprint-15

Conversation

@edgarbnt
Copy link
Copy Markdown
Owner

No description provided.

edgarbnt and others added 4 commits May 10, 2026 18:21
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ides

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…release gate

- Add community standard files: CONTRIBUTING.md, SECURITY.md, CODE_OF_CONDUCT.md
- Add .github/ISSUE_TEMPLATE/ with bug_report, feature_request, good_first_issue YAMLs
- Add .github/PULL_REQUEST_TEMPLATE.md with validation checklist
- Add .github/workflows/ci.yml (Node 20+22, check+build+test-app build)
- Add assets/social-preview.svg (1280x640 dark-theme placeholder)
- Wire social-preview.svg into README.md
- Add docs/github-visibility-plan.md (description, topics, labels, draft issues, badges)
- Add docs/release-gate.md (manual publish checklist, dry-run, rollback plan)
- Add docs/sprints/SPRINT15.md

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This Sprint 15 PR prepares React-Sentinel for public adoption by formalizing the scoped npm package contract, expanding init-mcp support across multiple MCP clients/IDEs (including VS Code/Copilot), and refreshing documentation + repository hygiene for public readiness.

Changes:

  • Expanded MCP config generation/validation to support multiple clients (Cursor, Gemini CLI, GitHub Copilot/VS Code) and both mcpServers and servers root shapes.
  • Updated the CLI onboarding flow (init-mcp) with --client auto, client detection, and scoped package naming (@edgarbrunet/react-sentinel) while keeping the react-sentinel binary.
  • Added/rewrote public-facing docs and repo metadata (README refresh, SECURITY/CONTRIBUTING/CODE_OF_CONDUCT, CI workflow, release gate, sprint report).

Reviewed changes

Copilot reviewed 36 out of 40 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/mcp-config.ts Adds new MCP client targets, supports servers root key, and switches npx launch to the scoped package name.
src/index.ts Extends CLI init-mcp with auto-detection, multi-client targets, and updated help/output.
src/agent-pack.ts Adds Cursor as a documented agent-pack profile and ships the Cursor profile template.
SECURITY.md Introduces a security policy and private vulnerability reporting guidance.
README.md Rewrites README into a product/onboarding entrypoint aligned with the scoped package contract.
package.json Renames package to @edgarbrunet/react-sentinel and adds an npm files allowlist for publish hygiene.
package-lock.json Updates lock metadata to reflect the scoped package rename.
LICENSE Adds MIT license for public distribution.
examples/README.md Links example usage to the centralized local ports/endpoints doc.
docs/workflows.md Updates workflow docs to use init-mcp --client auto and scoped npx examples.
docs/universal-install.md Adds the universal install contract and target matrix for supported clients.
docs/sprints/SPRINT15.md Adds the Sprint 15 delivery report and validation checklist.
docs/sprints/SPRINT1.md Updates the Sprint 1 report references after moving historical blueprint content.
docs/release-gate.md Documents manual-only release steps and anti-automation guardrails for public launch.
docs/public-readiness-audit.md Captures a pre-cleanup audit and rationale for what stays/moves in a public repo.
docs/project-history/README.md Introduces a dedicated home for internal/historical notes.
docs/project-history/BLUEPRINT.fr.md Moves the historical French blueprint into project history.
docs/project-history/agent-rules/coding-style.fr.md Moves historical agent rule notes into project history (minor formatting tweak).
docs/local-ports.md Centralizes legitimate local URLs/ports used across docs, tools, and tests.
docs/local-diagnostics-checklist.md Links diagnostics guidance to the centralized local ports/endpoints list.
docs/integration-guides.md Adds per-environment wiring instructions (Claude, Cursor, Copilot/VS Code, Gemini, generic).
docs/github-visibility-plan.md Adds a manual visibility plan (topics/labels/badges/social preview) for public GitHub setup.
docs/agent-runtime-ux.md Adds guidance for when/how agents should use runtime inspection/replay/sandbox modes.
docs/agent-pack.md Updates agent-pack docs to reflect scoped npx usage and Cursor adaptation.
docs/adoption-checklist.md Adds onboarding validation scenarios for Sprint 15 targets and flows.
CONTRIBUTING.md Adds contributor setup and validation instructions for public collaboration.
CODE_OF_CONDUCT.md Adds community behavior and enforcement expectations.
assets/social-preview.svg Adds a placeholder social preview asset referenced by README/visibility plan.
assets/agent-pack/skills/react-sentinel-debug.md Updates recommended tool order and adds stronger “assert before patch” guidance.
assets/agent-pack/profiles/generic-mcp.md Notes the scoped public package name for npm-based usage.
assets/agent-pack/profiles/cursor.md Adds Cursor profile adaptation notes.
assets/agent-pack/profiles/copilot-cli.md Adds a note about VS Code workspace .vscode/mcp.json as a reasonable config carrier.
assets/agent-pack/docs/heuristics.md Adds a recommended MCP tool call order aligned with replay-first workflows.
assets/agent-pack/docs/compatibility.md Updates compatibility matrix to include Cursor and refine Copilot notes.
.github/workflows/ci.yml Adds CI workflow for type-check/build plus demo app build on Node 20/22.
.github/PULL_REQUEST_TEMPLATE.md Adds PR template with explicit validation checklist.
.github/labels.yml Adds a declarative GitHub label set aligned with the visibility plan.
.github/ISSUE_TEMPLATE/good_first_issue.yml Adds a “good first issue” issue form template.
.github/ISSUE_TEMPLATE/feature_request.yml Adds a feature request issue form template.
.github/ISSUE_TEMPLATE/bug_report.yml Adds a bug report issue form template.

Comment thread src/index.ts Outdated
Comment on lines 492 to 500
return {
options: {
client: client as InitMcpCommandOptions["client"],
mode,
serverName,
replayHeadless: parsed.values.headed ? false : true,
write: parsed.values.write,
configPath: parsed.values["config-path"] ?? null,
},
Comment thread src/index.ts
Comment on lines +814 to 818
const resolvedClient = options.client === "auto" ? await detectInitMcpClient(process.cwd()) : options.client;
const clientDefinition = getInitMcpClientDefinition(resolvedClient);
const document = buildMcpConfigDocument({
client: options.client,
rootKey: clientDefinition.rootKey,
mode: options.mode,
@edgarbnt
Copy link
Copy Markdown
Owner Author

@copilot apply changes based on the comments in this thread

Agent-Logs-Url: https://github.com/edgarbnt/ReactSentinel/sessions/91a361dd-0b7c-44ac-814b-b33d845158ca

Co-authored-by: edgarbnt <146716791+edgarbnt@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 10, 2026

@copilot apply changes based on the comments in this thread

Implemented in 53b9074. I fixed parseInitMcpOptions so write and configPath are correctly inside options, and updated runInitMcp so snippet rootKey is derived from the resolved write target path (including --config-path) to stay consistent with file writes.

@edgarbnt
Copy link
Copy Markdown
Owner Author

@copilot the CI doesn't pass, i want u to look a this issue

Agent-Logs-Url: https://github.com/edgarbnt/ReactSentinel/sessions/740abd13-112b-4d5b-851f-13086f8533be

Co-authored-by: edgarbnt <146716791+edgarbnt@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

Copilot AI commented May 10, 2026

@copilot the CI doesn't pass, i want u to look a this issue

Fixed in 86251e2. I investigated the failing CI runs and the break was in examples/test-app using npm ci without a lockfile. I updated CI to use npm install for that step, and local validation now passes for the same path (npm install && npm run build in examples/test-app, plus root npm ci && npm run check && npm run build).

@edgarbnt edgarbnt merged commit 0f19637 into main May 10, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants