e2e: use json-patch to patch reference values in manifest #2139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katexochen
reviewed
Jan 29, 2026
| patchedManifest := patchFn(m) | ||
| patchedManifest, err := patchFn(m) | ||
| if err != nil { | ||
| return err |
Comment on lines
+49
to
+55
| declare -A specs=( | ||
| ["Metal-QEMU-SNP"]="./dev-docs/e2e/palutena/manifest.json" | ||
| ["Metal-QEMU-TDX"]="./dev-docs/e2e/olimar/manifest.json" | ||
| ["Metal-QEMU-SNP-GPU"]="./dev-docs/e2e/discovery/manifest.json" | ||
| ["Metal-QEMU-SNP-DEV"]="./dev-docs/e2e/hetzner-ax162-snp/manifest.json" | ||
| ["Metal-QEMU-TDX-GPU"]="./dev-docs/e2e/l-bgx-02/manifest.json" | ||
| ) |
Member
There was a problem hiding this comment.
Could we maybe use something like
./dev-docs/e2e/$(hostname)/manifest.json
instead?
Member
There was a problem hiding this comment.
If you like, open an upstream PR in nixpkgs with this! Otherwise I can take care of that. :)
Also, try to use nix-init to get a boilerplate for packaging upstream stuff, it will fetch all the required metadata!
| fetchFromGitHub, | ||
| }: | ||
|
|
||
| buildGoModule { |
Member
There was a problem hiding this comment.
Suggested change
| buildGoModule { | |
| buildGoModule (finalAttrs: { |
|
|
||
| buildGoModule { | ||
| pname = "json-patch"; | ||
| version = "v5.9.11"; |
Member
There was a problem hiding this comment.
Suggested change
| version = "v5.9.11"; | |
| version = "5.9.11"; |
| src = fetchFromGitHub { | ||
| owner = "evanphx"; | ||
| repo = "json-patch"; | ||
| rev = "v5.9.11"; |
Member
There was a problem hiding this comment.
Suggested change
| rev = "v5.9.11"; | |
| tag = "v${finalAttrs.version}"; |
| modRoot = "v5"; | ||
|
|
||
| vendorHash = "sha256-W6XVd68MS0ungMgam8jefYMVhyiN6/DB+bliFzs2rdk="; | ||
| } |
Member
There was a problem hiding this comment.
Please add meta attribute (use nix-init).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it easier to apply the reference values to the current manifest, thus making it easier to update the refernce values and configure reference values per host.