scripts: pass tags to modernize#2371
Merged
Merged
Conversation
Member
Author
That's where I found the error messages to begin with. I assumed that the |
burgerdev
force-pushed
the
burgerdev/modernize
branch
from
b3b847e to
5c3e1dc
Compare
Both `go fix` and `modernize` use the GOFLAGS environment variable, so we don't need to specify a flag for it.
This mirrors our go build configurations, which always set it the same way. Furthermore, there's an issue in CI where containers/storage tries to compile btrfs C code and fails in some workers. This does not happen without CGo.
burgerdev
force-pushed
the
burgerdev/modernize
branch
from
5c3e1dc to
5fc654f
Compare
Member
Author
|
@charludo fixed the other issue in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.