docs: fix gh-pages races and fix manual dispatch for docs publish workflow#2420
Open
sespiros wants to merge 2 commits into
Open
docs: fix gh-pages races and fix manual dispatch for docs publish workflow#2420sespiros wants to merge 2 commits into
sespiros wants to merge 2 commits into
Conversation
|
charludo
requested changes
May 28, 2026
| (github.event_name == 'pull_request' && github.repository_owner == github.event.pull_request.head.repo.owner.login) | ||
| env: | ||
| PREVIEW: ${{ !(github.event_name == 'push' && github.ref_name == 'main') }} | ||
| PREVIEW: ${{ github.event_name == 'pull_request' }} |
Collaborator
There was a problem hiding this comment.
Does this not mean a manual dispatch does a real publication? IMO that should not be possible unless we merge into main. What's the motivation behind the condition change?
Collaborator
Author
There was a problem hiding this comment.
Yes. Yesterday I merged the update release PR and another docs change PR (to update the debugshell page). These triggered 2 gh-pages publish jobs which they raced and as a result the release to main docs got published but my changes to the debugshell docs didn't (you can visit the docs->next and check the debugshell page). The docs will be updated when some other update to main touches the docs but I don't see why couldn't we dispatch the workflow ourselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.