Skip to content

fix codegen cycle, fix govulncheck findings#2421

Open
charludo wants to merge 2 commits into
mainfrom
ch/govulncheck-again
Open

fix codegen cycle, fix govulncheck findings#2421
charludo wants to merge 2 commits into
mainfrom
ch/govulncheck-again

Conversation

@charludo
Copy link
Copy Markdown
Collaborator

Instead of just bumping the dependency, this PR includes a second commit that breaks a cycle we had when running just codegen.

Previously,

  • contrast.node-installer inherits vendorHash from contrast.contrast (as do cli, e2e, resourcegen)
  • to update this one, shared vendorHash, building nodeinstaller is required, because the reference-values depend on it, and e.g. the cli requires those to build
  • this requires the vendorHash already be correct

Fixed it by moving from pre/postPatch to pre/postConfigure hooks. This causes them to no longer propagate into the goModules vendorHash. They still effect our package's output hashes, of course.

@charludo charludo requested a review from sespiros May 28, 2026 07:09
@charludo charludo added the no changelog PRs not listed in the release notes label May 28, 2026
Copy link
Copy Markdown
Collaborator

@sespiros sespiros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I am curious how we did the Go updates with that dep cycle in place...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PRs not listed in the release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants