Skip to content

Display number of read URLs on options page. #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colossatr0n wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Display number of read URLs on options page. #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
292b748
Display number of read URLs on the options page.
colossatr0n May 6, 2022
9af701e
Fix whitespace.
colossatr0n May 6, 2022
b59a121
Move number of read URLs to bottom of page.
colossatr0n May 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions markasread/options.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,5 +18,9 @@ <h3>Clear</h3>
<p>WARNING! This will delete all stored data regarding sites you've visited!</p>
<button id="clear">Clear All Stored Data</button>
</section>
<section>
<h3>Number of URLs Read</h3>
<div id="visited-count"></div>
</section>
</body>
</html>
12 changes: 11 additions & 1 deletion markasread/options.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,15 @@ function upload() {
upload.value = '';
}

async function getVisitedCount() {
const obj = await chrome.storage.local.get("visited")
Copy link
Copy Markdown
Owner

@edoreld edoreld May 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error on calling this line

Uncaught (in promise) TypeError: Error in invocation of storage.get(optional [string|array|object] keys, function callback): No matching signature.
    at getVisitedCount (options.js:24:44)
    at HTMLDocument.<anonymous> (options.js:46:64)

I believe you need to use chrome.storage.local.get("visited", function(obj) instead, as done elsewhere in the project.

const visited = obj["visited"]
return Object.keys(visited)
.filter(key => key != "version")
.flatMap(key => visited[key])
.length
}

function openDialog() {
document.getElementById('upload').click();
}
Expand All @@ -28,9 +37,10 @@ function clearData() {
chrome.storage.local.clear();
}

document.addEventListener('DOMContentLoaded', function() {
document.addEventListener('DOMContentLoaded', async function() {
document.getElementById("download").addEventListener("click", download);
document.getElementById('upload').addEventListener("change", upload, false);
document.getElementById("import").addEventListener('click', openDialog);
document.getElementById("clear").addEventListener('click', clearData)
document.getElementById("visited-count").innerText = await getVisitedCount()
}, false);