Conversation
There was a problem hiding this comment.
Pull request overview
This PR transitions version 0.5.2-beta.0 to the stable 0.5.2 release, exiting pre-release mode. The release includes a fix for Android vertical offset issues when using navigation buttons instead of gestures, originally implemented in PR #19.
Changes:
- Version bumped from 0.5.2-beta.0 to 0.5.2 in package.json
- Added changelog entry for version 0.5.2 documenting the Android offset fix
- Removed pre-release configuration (.changeset/pre.json) to exit beta mode
- Removed consumed changeset file (.changeset/plain-jokes-roll.md)
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates version from 0.5.2-beta.0 to 0.5.2 for stable release |
| CHANGELOG.md | Adds 0.5.2 release entry documenting the Android vertical offset fix |
| .changeset/pre.json | Removes pre-release mode configuration file |
| .changeset/plain-jokes-roll.md | Removes consumed changeset file after incorporation into changelog |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| ### Patch Changes | ||
|
|
||
| - [`1e18f04`](https://github.com/edwardloopez/react-native-coachmark/commit/1e18f04a7b07c90a4e421adb4bdea9afde6c1029) Thanks [@edwardloopez](https://github.com/edwardloopez)! - Fix Android vertical offset when using navigation buttons instead of gestures |
There was a problem hiding this comment.
There is a discrepancy between the changelog entry and the PR description. The PR description references commit hash f1cf1fd and credits @christian-jayme for the fix, while this changelog entry references commit hash 1e18f04 and credits @edwardloopez. Additionally, the PR description provides more detailed context about the fix (Modal now uses statusBarTranslucent and screen dimensions on Android), which is missing from this changelog entry. The changelog should either reference the correct commit from PR #19 or provide consistent attribution and details.
There was a problem hiding this comment.
@copilot open a new pull request to apply changes based on this feedback
|
@edwardloopez I've opened a new pull request, #23, to work on those changes. Once the pull request is ready, I'll request review from you. |
[WIP] WIP Address feedback from PR #22 on version package changes
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
@edwardloopez/react-native-coachmark@0.5.2
Patch Changes
f1cf1fdThanks @christian-jayme! - Fix Android vertical offset when using navigation buttons instead of gestures. Modal now uses statusBarTranslucent and screen dimensions on Android to align coachmark holes correctly with target elements.