fix: expose renderTooltip option in createTour DSL#26
Merged
edwardloopez merged 1 commit intomainfrom Mar 28, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the createTour() DSL helper to support the already-existing Tour.renderTooltip option, making it possible to configure a global custom tooltip renderer when defining tours via the DSL (addressing issue #25).
Changes:
- Extend
createTour()options to acceptrenderTooltip?: TooltipRenderer. - Propagate
renderTooltipfromoptsonto the returnedTourobject. - Add a Jest test asserting that
renderTooltipis preserved.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
src/dsl/createTour.ts |
Adds renderTooltip to the DSL options and returns it on the Tour object. |
src/core/types.ts |
Minor cleanup: removes an inline comment from TourStep (no behavioral change). |
src/__tests__/createTour.test.ts |
Adds coverage verifying renderTooltip is set when passed to createTour(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The Tour type already defined renderTooltip?: TooltipRenderer but createTour() did not accept or propagate it, making the global custom tooltip renderer inaccessible via the DSL. - Add renderTooltip to createTour opts parameter - Import TooltipRenderer type in createTour.ts - Add test coverage for the new option Closes #25
edwardloopez
force-pushed
the
fix/create-tour-render-tooltip
branch
from
10c8bad to
fdf324c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Tour type already defined renderTooltip?: TooltipRenderer but createTour() did not accept or propagate it, making the global custom tooltip renderer inaccessible via the DSL.
Closes #25