-
Notifications
You must be signed in to change notification settings - Fork 7
fix: update Python version to 3.11 and use latest setup-python action in workflows #317
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
10eb5c8
d2e12cb
7a61516
96244aa
5ad0191
4b1d3a6
917dce2
d3b0fdb
1c9317f
8c11f2f
f52e152
68195fc
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -12,27 +12,15 @@ | |
| # this file from Github directly. It does not require packaging in edx-lint. | ||
|
|
||
| # using LTS django version | ||
| Django<5.0 | ||
| Django<6.0 | ||
|
Comment on lines
14
to
+15
|
||
|
|
||
| # elasticsearch>=7.14.0 includes breaking changes in it which caused issues in discovery upgrade process. | ||
| # elastic search changelog: https://www.elastic.co/guide/en/enterprise-search/master/release-notes-7.14.0.html | ||
| # See https://github.com/openedx/edx-platform/issues/35126 for more info | ||
| elasticsearch<7.14.0 | ||
|
|
||
| # django-simple-history>3.0.0 adds indexing and causes a lot of migrations to be affected | ||
| django-simple-history==3.0.0 | ||
|
|
||
| # Cause: https://github.com/openedx/event-tracking/pull/290 | ||
| # event-tracking 2.4.1 upgrades to pymongo 4.4.0 which is not supported on edx-platform. | ||
| # We will pin event-tracking to do not break existing installations | ||
| # This can be unpinned once https://github.com/openedx/edx-platform/issues/34586 | ||
| # has been resolved and edx-platform is running with pymongo>=4.4.0 | ||
| event-tracking<2.4.1 | ||
|
|
||
| # Cause: https://github.com/openedx/edx-lint/issues/458 | ||
| # This can be unpinned once https://github.com/openedx/edx-lint/issues/459 has been resolved. | ||
| pip<24.3 | ||
|
|
||
| # Cause: https://github.com/openedx/edx-lint/issues/475 | ||
| # This can be unpinned once https://github.com/openedx/edx-lint/issues/476 has been resolved. | ||
| urllib3<2.3.0 | ||
| # pip 26 is incompatible with pip-tools hence causing failures during the build process | ||
| # Make upgrade command and all requirements upgrade jobs are broken due to this. | ||
| # The constraint can be removed once a release (pip-tools > 7.5.2) is available with support for pip 26 | ||
| # Issue to track this dependency and unpin later on: https://github.com/jazzband/pip-tools/issues/2319 | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm... looks like that issue has closed. Can we use newer pip now? (But I'm fine with merging as is. It's not like we need a newer pip or pip-tools for this repo anyhow.) |
||
| pip<26.0 | ||
|
Comment on lines
+22
to
+26
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,11 @@ | ||
| -c common_constraints.txt | ||
|
|
||
| bcrypt<3.2.0 # 3.2.0 dropped support for python 2.7 | ||
|
|
||
| # Python 3.9 reached EOL in October 2025 and was removed from GitHub Actions runners | ||
| # GitHub Actions workflows now use Python 3.11 | ||
| # Ansible 9+ supports Python 3.11+ but removed the deprecated 'include' syntax causing playbook failures | ||
| # Ansible 8.7.0 is the latest version that supports both Python 3.11 AND the deprecated 'include' syntax | ||
| # The constraint can be removed once all 63 instances of 'include' are migrated to 'include_tasks' or 'import_tasks' | ||
| # Tracking: Configuration playbooks need migration before upgrading to Ansible 9+ | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There should already be a ticket for this. We should link to it. Also, we should not in the ticket (if not already noted) that cleaning up edxapp ansible usage before upgrade should simplify it. |
||
| ansible<9.0.0 | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be 3.12? (To match requirements file.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, plan is to update this to 3.12. But current challenge is Ansible 9+ removed support for deprecated include syntax used in playbooks and lower version(ansible<9.0.0) is not supported on 3.12.
Plan is to create a separate PR which will require a SRE support where they can validate all the changes and update this to 3.12 with updated Ansible version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, thanks! (Might be good to include this in the PR description, and the commit message when you squash.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
requirements3_11.txt(assuming we even need multiple requirements files), would help avoid some confusion.