Fix strncpy sizeof + missing WiFi include for ESP32#33
Open
cdamman wants to merge 3 commits intoeelcohn:masterfrom
Open
Fix strncpy sizeof + missing WiFi include for ESP32#33cdamman wants to merge 3 commits intoeelcohn:masterfrom
cdamman wants to merge 3 commits intoeelcohn:masterfrom
Conversation
Author
cdamman
changed the title
cdamman
force-pushed
the
fix-strncpy-sizeof
branch
from
77d88c8 to
7b6f9ca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
Thank you very much for this awesome project!
During deployment, I noticed that changing the password did not worked.
It was simply a little bug, using
sizeof(SIZE)instead ofSIZEdirectly in moststrncpycalls.Just fixed it in this PR.
I also fixed the missing declaration of
FAN_FRAME_04and some cosmetic in prints.