TASK-2025-02771: Convert Task override to extended class inheritance#595
Open
anjusha12 wants to merge 1 commit intoversion-15from
Open
TASK-2025-02771: Convert Task override to extended class inheritance#595anjusha12 wants to merge 1 commit intoversion-15from
anjusha12 wants to merge 1 commit intoversion-15from
Conversation
MhmdSinanKT
approved these changes
Dec 1, 2025
34d4487 to
48de43b
Compare
SherinKR
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature description
Refactor Task doctype override from complete NestedSet replacement to extended class inheritance, maintaining only custom validate_status logic while leveraging ERPNext's core Task functionality.
Analysis and design (optional)
Analyse and attach the design documentation
Solution description
Class Inheritance: Changed
class CustomTask(NestedSet)toclass CustomTask(Task)Removed Duplicate Methods: Eliminated 20+ methods that duplicated ERPNext functionality:
Retained Custom Logic: Only kept
validate_status()method with custom behavior:ignore_dependent_task_validationis enabledRemoved Auto-generated Types: Type annotations now inherited from parent Task class
Output screenshots (optional)
Post the output screenshots, if a UI is affected or added due to this feature.
Areas affected and ensured
Is there any existing behavior change of other features due to this code change?
Mention Yes or No. If Yes, provide the appropriate explanation.
Was this feature tested on the browsers?