fix(sales): percentage invoicing – use remaining amount and per-item %#56
Open
ajmalroshan123 wants to merge 1 commit intodevelopfrom
Open
fix(sales): percentage invoicing – use remaining amount and per-item %#56ajmalroshan123 wants to merge 1 commit intodevelopfrom
ajmalroshan123 wants to merge 1 commit intodevelopfrom
Conversation
Collaborator
|
task? @ajmalroshan123 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature description
Percentage-based invoicing from Sales Order: create Sales Invoices by entering a percentage (for the whole order or per item). Service items use percentage of amount; stock items use percentage of quantity. Sales Order Item shows Invoiced Amount and Remaining Amount, and the popup shows per-item remaining % and lets you set Invoice % per line.
Solution description
Backend: get_so_items always computes billed/remaining from submitted Sales Invoices and returns per-item remaining_amt_percentage. make_sales_invoice_by_percentage applies Invoice % to line total (capped at remaining amount) in per-item mode, and uses order-level fraction in “Same % for all” mode. Sales Order Item custom fields invoiced_amount and remaining_amount are updated on Sales Invoice submit/cancel.
Frontend: popup has Remaining % column, default Invoice % from per-item remaining, Include and “Same % for all” unchecked by default, and compact options layout.
Output screenshots (optional)
Was this feature tested on the browsers?