testutil: remove unnecessary formatting on err#10
Merged
saswatamcode merged 2 commits intoefficientgo:mainfrom May 9, 2025
Merged
testutil: remove unnecessary formatting on err#10saswatamcode merged 2 commits intoefficientgo:mainfrom
saswatamcode merged 2 commits intoefficientgo:mainfrom
Conversation
Error can contain stuff like %s and then that gets interpreted as a format string command. That's really not the intention here. Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
saswatamcode
approved these changes
May 9, 2025
Signed-off-by: Giedrius Statkevičius <giedrius.statkevicius@vinted.com>
GiedriusS
force-pushed
the
testutil_rm_formatting
branch
from
8856a81 to
36c8090
Compare
Contributor
Author
|
I'm not trusted on this repo, so GitHub is probably continuing to run the version from |
Collaborator
|
Ack I think this PR is fine to merge, can address the actions versions in next PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error can contain stuff like %s and then that gets interpreted as a format string command. That's really not the intention here.