Skip to content

Add checkbox to show times for today only in Kapten Alloc#11

Open
Poiku wants to merge 8 commits into
mainfrom
kaptenalloctoday
Open

Add checkbox to show times for today only in Kapten Alloc#11
Poiku wants to merge 8 commits into
mainfrom
kaptenalloctoday

Conversation

@Poiku
Copy link
Copy Markdown
Collaborator

@Poiku Poiku commented Oct 10, 2025

It's not very well tested and the code could be prettier but I think it works (if merge make the code look better pls)

@Poiku Poiku requested a review from eflisback October 10, 2025 14:43
@eflisback
Copy link
Copy Markdown
Owner

@Poiku see if you can completely replace the previous checkbox so that they don't overlap in responsibilities. once that's done, ping me and I will review 🤓

@Poiku
Copy link
Copy Markdown
Collaborator Author

Poiku commented Oct 10, 2025

Yes master 🙏

@JuliusNicklas
Copy link
Copy Markdown
Collaborator

@eflisback
Jag har tagit bort onödig checkbox, och mergade. Det borde nu vara klart att mergas.
Jag är dock osäker på om jag borde använda selectedId.isDefined för showToday?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants