This repository was archived by the owner on Feb 20, 2019. It is now read-only.
adding time conversion function#180
Open
AKASHAGARWAL0403 wants to merge 3 commits intoeggheadio-github:masterfrom
Open
adding time conversion function#180AKASHAGARWAL0403 wants to merge 3 commits intoeggheadio-github:masterfrom
AKASHAGARWAL0403 wants to merge 3 commits intoeggheadio-github:masterfrom
Conversation
kentcdodds
suggested changes
Jun 26, 2018
Member
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
Good start! If you checkout the build you'll see why it's failing. It's due to linting issues. Please fix those! You can run this locally with npm run validate.
Good luck!
Member
|
Hi @AKASHAGARWAL0403! Looking good! Now it looks like we're missing some coverage. Open up |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.