Open
Conversation
Owner
|
This looks good, although the tests don't seem to pass. (I've been meaning to convert to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having a go at issue #52
Adds a command line parameter --override_currency="YOUR_CURRENCY" which is then set as the currency for the print out. It also supports --override_currency="" which is my use case, where all my entries to date simply don't have a currency and that's the way I like them.
I think this is roughly following the conventions for how you've got for new code. I tried to write up a test, but the truth is I haven't been able to successfully run the test suite on my local machine, so I'm not sure if it'll pass although I think it looks about right...