Skip to content

docs: align wet-lab feedback intake#137

Merged
munkyukim86 merged 1 commit into
mainfrom
docs/align-wet-lab-feedback-intake
Jun 27, 2026
Merged

docs: align wet-lab feedback intake#137
munkyukim86 merged 1 commit into
mainfrom
docs/align-wet-lab-feedback-intake

Conversation

@munkyukim86

Copy link
Copy Markdown
Contributor

Summary

Audit of the FactorForge public-safe wet-lab feedback -> AgentOps -> ValidationHub pipeline found that .github/ISSUE_TEMPLATE/wet_lab_result.yml is the actual source of truth for wet-lab feedback fields, but supporting docs and template config had drifted from it. This is the first low-risk operational PR in that pipeline (intentionally narrow — see Non-goals).

  • Add a default issue title: and the existing user-feedback label to wet_lab_result.yml (alongside wet-lab, needs-triage — all three labels already exist in this repo)
  • Disable blank_issues_enabled to reduce the chance of sensitive wet-lab/construct details landing in an untemplated public issue. Tradeoff: general bug/feature/idea reports must now use a template, but bug_report.yml / feature_request.yml / idea.yml already cover those cases, and the email contact link remains for anything that doesn't fit.
  • Sync docs/feedback-inbox.md and docs/validation.md field lists to the actual template fields, removing references to harvest_timepoint, institution_disclosure, expression_system_assay_type, and "approximate yield range" — none of which are actually collected by the template.

Non-goals (explicitly out of scope)

  • AgentOps wet-lab issue parser/schema
  • GitHub Actions triage workflow on issues: opened/edited
  • Hermes Gateway / Discord integration
  • New lifecycle labels (accepted-feedback, needs-redaction, etc.) — deferred until the triage workflow that uses them exists
  • ValidationHub writes or any public-projection automation

Test plan

  • YAML parse check on both touched .github/ISSUE_TEMPLATE/*.yml files (pass)
  • gh label list confirms wet-lab, user-feedback, needs-triage exist in this repo
  • grep for removed field names (harvest_timepoint, institution_disclosure, expression_system_assay_type, yield range) across touched docs — 0 matches
  • grep for new overclaiming language (validated, proven, guarantee) — only pre-existing negation language present, no new claims introduced
  • Diff scope limited to exactly the 4 files listed above

🤖 Generated with Claude Code

Make .github/ISSUE_TEMPLATE/wet_lab_result.yml the single source of truth
for public-safe wet-lab feedback fields.

- Add default issue title and "user-feedback" label (label already exists
  in the repo's label set, alongside wet-lab/needs-triage)
- Disable blank issues to reduce accidental disclosure risk in this public
  repo; structured templates (bug/feature/idea/wet-lab) already cover the
  general cases, and the email contact link remains for anything else
- Sync docs/feedback-inbox.md and docs/validation.md field lists to the
  actual template fields, removing harvest_timepoint,
  institution_disclosure, expression_system_assay_type, and
  approximate-yield-range references that were never collected
@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
factorforge-cds Ready Ready Preview, Comment Jun 26, 2026 4:48am

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: bb2a52896b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/validation.md
- Protein class.
- Expression system / assay type.
- Harvest timepoint.
- Coarse assay category.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Synchronize VALIDATION.md with this field list

At this line the docs start enforcing the new, narrower public-safe field set, but the root VALIDATION.md that README/CONTRIBUTING send users to for the submission format still lists the old fields (Expression system / assay type, Harvest timepoint, and Approximate yield range). That leaves two public validation surfaces giving conflicting instructions, and users may still include fields this change is trying to remove from public intake; please update VALIDATION.md in the same change.

Useful? React with 👍 / 👎.

@munkyukim86 munkyukim86 merged commit 19473ae into main Jun 27, 2026
12 checks passed
@munkyukim86 munkyukim86 deleted the docs/align-wet-lab-feedback-intake branch June 27, 2026 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant