Skip to content

Comments

feat: add constructor option isLocalhost, replaces development#259

Open
wkillerud wants to merge 1 commit intomainfrom
isLocalhost
Open

feat: add constructor option isLocalhost, replaces development#259
wkillerud wants to merge 1 commit intomainfrom
isLocalhost

Conversation

@wkillerud
Copy link
Contributor

To remove confusion about when to set the value to true, f. ex. in development environments.

isLocalhost?: boolean;
/**
* @default false
* @deprecated Prefer `isLocalhost` instead for clarity.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do a proper deprecation warning: https://nodejs.org/api/util.html#utildeprecatefn-msg-code-options

Copy link
Contributor Author

@wkillerud wkillerud Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into that, seems to only be for whole functions.

Copy link

@leftieFriele leftieFriele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, the development flag isn't clear what it does. Especially if you are using Eik along with Podium.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants