feat: migrate select component to TypeScript#46
Open
devin-ai-integration[bot] wants to merge 3 commits into
Open
feat: migrate select component to TypeScript#46devin-ai-integration[bot] wants to merge 3 commits into
devin-ai-integration[bot] wants to merge 3 commits into
Conversation
Co-Authored-By: Eirik <eirik.haugstulen@gmail.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Co-Authored-By: Eirik <eirik.haugstulen@gmail.com>
Co-Authored-By: Eirik <eirik.haugstulen@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates the entire
selectcomponent from JavaScript to TypeScript. This includes all sub-modules:Changes made:
.jssource files to.ts/.tsx(40+ files)PropTypesimports and runtime prop type definitionsReact.Component<Props, State>tsconfig.jsonwith ES2023 lib and node typesd2.config.jsentry point fromsrc/index.jstosrc/index.tspackage.jsonbuild script to include post-build rename and addedtypecheckscript.tsx/.tsextensions.tsx/.tsextensionsjest.mock()paths in test files to reference new.tsxpathssrc/locales/index.d.tstype declaration for i18n modulelabelIdprop on Field in SimpleSingleSelectField for correct aria-labelledby associationVerification:
tsc --noEmitpasses with zero errorseslintpasses with zero errorsyarn buildsucceeds (134 files renamed, 114 imports updated by post-build script)@dhis2/ui-constants,@dhis2-ui/box). These same 9 failures exist on the base branch before the migration. The 1 test suite that can resolve its dependencies (debounce.spec.js) passes.Known issues
Checklist
Story and test files were not converted to TypeScript per migration guidelines - only their imports were updated to reference the new
.tsx/.tssource files.Link to Devin session: https://app.devin.ai/sessions/8a839787d0b845dd926f26d18c106875
Requested by: @eirikhaugstulen