This repository was archived by the owner on Oct 26, 2023. It is now read-only.
Added a feature that highlights posts with red border that contains words/phrases from a list#38
Open
kevinjpluck wants to merge 8 commits intoejensen:masterfrom
Open
Added a feature that highlights posts with red border that contains words/phrases from a list#38kevinjpluck wants to merge 8 commits intoejensen:masterfrom
kevinjpluck wants to merge 8 commits intoejensen:masterfrom
Conversation
Owner
|
Thank you for the pull request, Kevin. I've encountered a few issues with the new feature.
In commit ce1c3d9, I added the ability to highlight occurrences of words from a list. You may want to build upon that related feature. Maybe build a sub-option that highlights the entire message (if that's your desired effect), in addition to highlighting the keyword. Hope that helps, and thanks again! |
Author
|
Thanks Eric, I'll have a look at your issues, correct them and get back to you. I'm a tad new to js and chrome extensions so any criticism is appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Eric,
We found that our campfire room got quite noisy with hubot etal posting errors and warnings so a lot of critical messages got lost. So instead of retuning hubot (which is probably the sensible approach) I added this feature to kindling.
I hope you like it :-)