Fix last kitty card clipped in RoundCompleteModal#421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The rightmost kitty card in the round complete modal was having its right half cut off.
Root cause: The modal has
overflow: hiddenand each card wrapper is only 40px wide (to enable the overlapping stack effect). For middle cards the overflow is hidden behind the next card, but the last card had nothing covering it — so ~25px of it (border + shadow included) was clipped.Fix: Give the last card wrapper the full card width (72px, accounting for the 65px card + border + shadow) so it renders completely.