Allow setting tag message with $EDITOR.#1
Allow setting tag message with $EDITOR.#1ryneeverett wants to merge 2 commits intoekohl:annotated-tagsfrom
Conversation
Both Git and Mercurial have the option to write an annotated tag in the $EDITOR. Expose this when --tag-message is passed with no argument.
bumpversion/__init__.py
Outdated
| subprocess.check_output(command) | ||
| elif message is None: | ||
| command += ['--annotate'] | ||
| subprocess.call(command) |
There was a problem hiding this comment.
This doesn't check the exit status like check_output did. There is check_call. Since the project is marked Python 2.7+ I don't think that'll be a problem.
There was a problem hiding this comment.
Turns out I was confused with check_output (which is 2.7+), check_call exists since 2.5 so even less of a problem.
|
This changes it to always tag with a message and I'd like to keep the option not to tag with a message. |
I don't think this commit changes that behavior -- |
- subprocess.call -> subprocess.check_call - Fix test.
|
I was slightly surprised there was no test for 'without message' so I'm going to verify. Otherwise I think this is looking like a nice addition to my patch. |
|
Thanks for the review. At first I was thinking this should be merged into your branch/PR but now I'm thinking I should submit it as a separate PR to upstream. It doesn't change much of your work and given that #58 has been under review for over a year it would be a shame to start the review process over. Thoughts? |
|
I was thinking of further reviewing your comments and then keep it as a separate commit. That should make reviewing simple enough. I don't think the size of peritus#58 matters that much, there's simply a lack of time at all. |
|
Cool. |
|
My apologies for never getting around to it. I'm going to close this now but please open a PR against https://github.com/c4urself/bump2version which is a fork and released on pypi. |
2 participants
Both Git and Mercurial have the option to write an annotated tag in the
$EDITOR. Expose this when --tag-message is passed with no argument.