Fix closeModal invoked right after openModal when used in stencilJS Web Component with Maplibre#22
Open
Fix closeModal invoked right after openModal when used in stencilJS Web Component with Maplibre#22
Conversation
added 2 commits
April 12, 2022 13:39
Owner
|
Hi, Thanks for taking the time to create a pr, however, this would mean a difference in functionality. we don't want to only listen the container. Maybe it can be a fallback instead? |
el
requested changes
Apr 13, 2022
| } | ||
| this.styleButton.classList.add("mapboxgl-ctrl-icon"); | ||
| this.styleButton.classList.add("mapboxgl-style-switcher"); | ||
| this.styleButton.addEventListener("click", event => |
Owner
There was a problem hiding this comment.
Please dont update the coding style of the project
Author
There was a problem hiding this comment.
ops, sorry, I hope to have reverted to original code style now
Author
|
hello :) thanks for the replies. I added an optional flag in the constructor to bind the click event to the mapContainer if is set to true. do you think this could be a good approach? Thanks!!! |
Owner
|
I think a better approach would be to detect if the code is running inside a shadow root or not and bind accordingly. Sorry, it took a while for me to respond, I had covid last week. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see issue #21