Skip to content

Remove costly useless ConvertToHex calls #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
remye06 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove costly useless ConvertToHex calls #152

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions Transport/BacnetIpUdpProtocolTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,7 +227,6 @@ private void OnReceiveData(IAsyncResult asyncResult)
}
}

var receiveBufferHex = ConvertToHex(receiveBuffer);
var receivedLength = receiveBuffer.Length;

if (receivedLength == 0) // Empty frame : port scanner maybe
Expand All @@ -238,7 +237,7 @@ private void OnReceiveData(IAsyncResult asyncResult)

if (receivedLength < BVLC.BVLC_HEADER_LENGTH)
{
Log.Warn($"Some garbage data got in: {receiveBufferHex}");
Log.Warn($"Some garbage data got in: {ConvertToHex(receiveBuffer)}");
return;
}

Expand All @@ -247,7 +246,7 @@ private void OnReceiveData(IAsyncResult asyncResult)

if (headerLength == -1)
{
Log.Warn($"Unknow BVLC Header in: {receiveBufferHex}");
Log.Warn($"Unknow BVLC Header in: {ConvertToHex(receiveBuffer)}");
return;
}

Expand Down Expand Up @@ -280,7 +279,7 @@ private void OnReceiveData(IAsyncResult asyncResult)

if (receivedLength <= headerLength)
{
Log.Warn($"Missing data, only header received: {receiveBufferHex}");
Log.Warn($"Missing data, only header received: {ConvertToHex(receiveBuffer)}");
return;
}

Expand Down