feat(otel-node): add fs instrumentation#601
Merged
Merged
Conversation
trentm
approved these changes
Feb 10, 2025
| | `@opentelemetry/instrumentation-cassandra-driver` | `cassandra-driver` version range `>=4.4.0 <5` | [README](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-cassandra#readme) | | ||
| | `@opentelemetry/instrumentation-express` | `express` version range `^4.0.0` | [README](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-express#readme) | | ||
| | `@opentelemetry/instrumentation-fastify` | `fastify` version range `>=3 <5` | [README](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/opentelemetry-instrumentation-fastify#readme) | | ||
| | `@opentelemetry/instrumentation-fs` | `fs` module for Node.js `>=14` | [README](https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node/instrumentation-fs#readme) | |
Member
There was a problem hiding this comment.
for Node.js
>=14
I wonder if we should drop the "for Node.js [VERSION]" specifier now. We've bumped our min-supported Node.js now. Rather than having that version range in a multiple places, it can just be once in the "Node.js versions" section. Anyway, this can be done separately.
Member
Author
There was a problem hiding this comment.
We could rewrite it to
`fs` module for suppported Node.js versions
and apply the same for other node:* instrumentations like net
Co-authored-by: Trent Mick <trent.mick@elastic.co>
trentm
approved these changes
Feb 10, 2025
Member
Author
|
I'll merge after #603 is complete. This instrumentation can go into next version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
@opentelenetry/instrumentation-fsand follows the consensus of the OTEL JS SIG on having it disabled by default.ref: open-telemetry/opentelemetry-js-contrib#2453
ref: #240 (comment)
The included tests check for enabling it via environment variable but not via passing a config object in
getInstrumentationsmethod.@trentm let's discuss if test is needed and also where to put in the docs how to enable the instrumentation.
Closes: #240