Skip to content

refactor!: clean ESQLMessage interface#83

Merged
sddonne merged 2 commits intomainfrom
clean-esql-message
Apr 14, 2026
Merged

refactor!: clean ESQLMessage interface#83
sddonne merged 2 commits intomainfrom
clean-esql-message

Conversation

@sddonne
Copy link
Copy Markdown
Contributor

@sddonne sddonne commented Apr 10, 2026 •
edited
Loading

Summary

ESQLMessage interface should not be part of this package as it belongs to the validation domain.

BREAKING CHANGE: ESQLMessage interface is not exported any more.

Checklist

  • Unit tests have been added or updated.
  • The proper documentation has been added or updated.
  • If this PR contains breaking changes, you have explained them using the BREAKING CHANGE: change syntax.
  • The PR title has the correct conventional commit label in the title, this is crucial for the correct versioning of this package. Check the following cheat shit.
    Title Label Release
    breaking: true (!) major
    feat minor
    fix patch
    refactor patch
    perf patch
    build patch
    docs patch
    chore patch
    revert patch

@sddonne sddonne marked this pull request as ready for review April 10, 2026 07:41
@sddonne sddonne requested a review from a team as a code owner April 10, 2026 07:41
@sddonne sddonne mentioned this pull request Apr 10, 2026
Merged
stratoula
stratoula approved these changes Apr 10, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes good call Seb

sddonne added a commit to elastic/kibana that referenced this pull request Apr 13, 2026
@sddonne
[ES|QL] ESQLMessage interface movement (#262424)
ce805af 
## Summary
`ESQLMessage` interface was moved to `@elastic/esql` by mistake, it is
part of the validation domain and should live in `@kbn/esql-language`
package.

This PR just brings the definition of the interface into
`@kbn/esql-language` and updates the imports.

PR removing the interface form esql-js:
elastic/esql-js#83
michel-laterman pushed a commit to michel-laterman/kibana that referenced this pull request Apr 13, 2026
@sddonne @michel-laterman
[ES|QL] ESQLMessage interface movement (elastic#262424)
9cd3907 
## Summary
`ESQLMessage` interface was moved to `@elastic/esql` by mistake, it is
part of the validation domain and should live in `@kbn/esql-language`
package.

This PR just brings the definition of the interface into
`@kbn/esql-language` and updates the imports.

PR removing the interface form esql-js:
elastic/esql-js#83
@sddonne sddonne merged commit a0d3f44 into main Apr 14, 2026
3 checks passed
@sddonne sddonne deleted the clean-esql-message branch April 14, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stratoula stratoula stratoula approved these changes

Assignees

No one assigned

Labels

v9.5-kibana

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sddonne @stratoula