Skip to content

chore: Update grammars#85

Merged
sddonne merged 4 commits intomainfrom
esql_grammar_sync_1776053024
Apr 13, 2026
Merged

chore: Update grammars#85
sddonne merged 4 commits intomainfrom
esql_grammar_sync_1776053024

Conversation

@elastic-vault-github-plugin-prod
Copy link
Copy Markdown
Contributor

@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot commented Apr 13, 2026

This PR updates the ES|QL grammars (lexer and parser) and PromQL grammars to match the latest version in Elasticsearch.

BREAKING CHANGE: CHANGE POINT command options can not longer be written in any order.
FROM index | CHANGE_POINT value AS type, pvalue ON key is no longer syntactically correct.

@elastic-vault-github-plugin-prod elastic-vault-github-plugin-prod bot requested a review from a team as a code owner April 13, 2026 04:03
@stratoula stratoula changed the title [ES|QL] Update grammars fix: Update grammars Apr 13, 2026
@stratoula
Copy link
Copy Markdown
Contributor

@sddonne can you fix here the PR title? The current one always complains at the CI

@sddonne sddonne changed the title fix: Update grammars chore!: Update grammars Apr 13, 2026
@stratoula stratoula changed the title chore!: Update grammars chore: Update grammars Apr 13, 2026
@sddonne sddonne requested a review from bartoval April 13, 2026 08:31
Copy link
Copy Markdown
Contributor

@bartoval bartoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is correct.
Probably, autocomplete in AFTER_AS_CLAUSE needs to be slightly modified -> suggest only the pipe).

Copy link
Copy Markdown
Contributor

@bartoval bartoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Chore change minor or patch, in the version? . Just to avoid to have version 1.10000000.1 in two months.

@sddonne
Copy link
Copy Markdown
Contributor

sddonne commented Apr 13, 2026

Question: Chore change minor or patch, in the version? . Just to avoid to have version 1.10000000.1 in two months.

Having BREAKING CHANGE on the merge commit message should release a major version.

(Edit: adding the release changelog)
image

Probably, autocomplete in AFTER_AS_CLAUSE needs to be slightly modified -> suggest only the pipe)

I have a draft with autocomplete changes, will ping you for review there later on :)

@sddonne sddonne merged commit ef81fa2 into main Apr 13, 2026
3 checks passed
@sddonne sddonne deleted the esql_grammar_sync_1776053024 branch April 13, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants