[ML] Make build timing regression check a soft failure#3004
Open
edsavage wants to merge 3 commits intoelastic:mainfrom
Open
[ML] Make build timing regression check a soft failure#3004edsavage wants to merge 3 commits intoelastic:mainfrom
edsavage wants to merge 3 commits intoelastic:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes the “Check build timing regressions” Buildkite step purely informational by ensuring the pipeline upload step itself is also soft-failing, matching the already-soft-failing analytics step it generates.
Changes:
- Add an optional
soft_failparameter toPipelineStep.generate_step(). - Use
soft_fail=Truefor the “Check build timing regressions” pipeline upload step so it never fails the overall build.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.buildkite/pipeline.json.py |
Marks the build timing regression check upload step as soft_fail=True. |
.buildkite/ml_pipeline/step.py |
Extends generate_step() to optionally emit "soft_fail": true on the generated Buildkite step. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
The "Check build timing regressions" pipeline step should never cause the overall build to be marked as failed. The generated analytics step already had soft_fail: true, but the upload step that creates it did not — so errors during pipeline upload (e.g. missing step dependencies) would still produce a hard failure. Add a soft_fail parameter to generate_step() and use it for the regression check, making both the upload and the analytics step soft-fail on any error. Made-with: Cursor
…lable The run-validation.cmake script supports an OPTIONAL flag to skip gracefully when Python 3 is not on the PATH. Pass it from the CI test runner so that environments without Python (e.g. the Linux Docker build image) don't fail the entire test step. Made-with: Cursor
edsavage
force-pushed
the
fix/soft-fail-regression-check
branch
from
efb7477 to
f3fda76
Compare
Skip the allowlist validation block if cmake/run-validation.cmake does not exist, so this change remains safe even if the graph validation feature is reverted independently. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
soft_fail: true, but the upload step that creates it did not — so errors during pipeline upload (e.g. missing step dependencies) would still produce a hard failure.soft_failparameter togenerate_step()and use it for the regression check step, making both the upload and the analytics step soft-fail on any error.Test plan
"soft_fail": trueon the upload stepLabeling as
>non-issueas this change is purely internal.Made with Cursor