Skip to content

[ML] Reapply: Run allowlist validation in PyTorch edge pipeline #3007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
edsavage wants to merge 1 commit into
base: main
Choose a base branch
from
+24 −1
Open

[ML] Reapply: Run allowlist validation in PyTorch edge pipeline #3007

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion .buildkite/scripts/steps/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,27 @@ else
-P cmake/run-all-tests-parallel.cmake || TEST_OUTCOME=$?
fi

# --- PyTorch allowlist validation ---
# When triggered from the PyTorch edge pipeline, run the Python-based
# allowlist validation which traces live HuggingFace models with the
# new PyTorch version and verifies every op is in ALLOWED_OPERATIONS.
VALIDATION_OUTCOME=0
if [[ "${GITHUB_PR_COMMENT_VAR_ACTION:-}" == "run_pytorch_tests" ]]; then
echo "--- Validating PyTorch allowlist against HuggingFace models"
cmake \
-DSOURCE_DIR="$(pwd)" \
-DVALIDATE_CONFIG="$(pwd)/dev-tools/extract_model_ops/validation_models.json" \
-DVALIDATE_PT_DIR="$(pwd)/dev-tools/extract_model_ops/es_it_models" \
-DVALIDATE_VERBOSE=TRUE \
-P cmake/run-validation.cmake || VALIDATION_OUTCOME=$?

if [[ $VALIDATION_OUTCOME -ne 0 ]]; then
echo "^^^ +++"
echo "Allowlist validation failed — the new PyTorch version may introduce ops not in ALLOWED_OPERATIONS."
echo "See dev-tools/extract_model_ops/README.md for how to update the allowlist."
fi
fi

# Upload test results
echo "--- Uploading test results"
TEST_RESULTS_ARCHIVE=${OS}-${HARDWARE_ARCH}-unit_test_results.tgz
Expand All @@ -117,4 +138,6 @@ else
echo "No test results archive created"
fi

exit $TEST_OUTCOME
if [[ $TEST_OUTCOME -ne 0 || $VALIDATION_OUTCOME -ne 0 ]]; then
exit 1
fi